Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coodirnator: optimize the detectiong timeout for ip conflict and gateway detection #4511

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4509

Special notes for your reviewer:

@cyclinder cyclinder linked an issue Jan 3, 2025 that may be closed by this pull request
@cyclinder cyclinder changed the title coodirnator: set timeout for ip and gateway detection coodirnator: optimize the detectiong timeout for ip conflict and gateway detection Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (5014593) to head (9a44cf3).
Report is 3 commits behind head on release-v0.9.

Files with missing lines Patch % Lines
pkg/utils/utils.go 83.58% 7 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-v0.9    #4511       +/-   ##
=================================================
+ Coverage          1.39%   80.62%   +79.22%     
=================================================
  Files                55       51        -4     
  Lines              6359     5578      -781     
=================================================
+ Hits                 89     4497     +4408     
+ Misses             6260      908     -5352     
- Partials             10      173      +163     
Flag Coverage Δ
unittests 80.62% <83.58%> (+79.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/utils/utils.go 68.86% <83.58%> (ø)

... and 55 files with indirect coverage changes

@cyclinder cyclinder force-pushed the 0.9_cp/coordinator_detect_timeout1 branch from 21d133c to 3b26c89 Compare January 3, 2025 03:35
@cyclinder cyclinder requested review from ty-dc and bzsuni as code owners January 3, 2025 03:48
@weizhoublue weizhoublue merged commit d5167b0 into spidernet-io:release-v0.9 Jan 3, 2025
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to cherry pick PR 4504 from cyclinder, to branch release-v0.9
2 participants